adriangb commented on PR #20414: URL: https://github.com/apache/datafusion/pull/20414#issuecomment-3934863737
> > From the PR description it isn't clear to me if you've run all of those commands to verify they work as expected. Maybe just update the description if they've all been manually verified. > > This is the only thing holding me up from hitting approve Ah sorry missed that. And it was a good call, there were some minor issues (falsa not properly declaring it's deps)... I've now run all of the commands manually and can confirm they work (as far as I can tell they do what they should be and I get no dep errors). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
