kazuyukitanimura commented on code in PR #604:
URL: https://github.com/apache/datafusion-comet/pull/604#discussion_r1675488328
##########
core/src/parquet/read/column.rs:
##########
@@ -124,19 +129,81 @@ impl ColumnReader {
bit_width,
is_signed,
} => match (bit_width, is_signed) {
- (8, true) => typed_reader!(Int8ColumnReader, Int8),
+ (8, true) => match promotion_info.physical_type {
+ PhysicalType::FIXED_LEN_BYTE_ARRAY => {
+ if promotion_info.precision <=
DECIMAL_MAX_INT_DIGITS
+ && promotion_info.scale < 1
Review Comment:
Yes, when `promotion_info.scale < 1`, it can be treated as regular integer.
Perhaps I can do the same for the promotion_info.precision <=
DECIMAL_MAX_LONG_DIGITS case. It is an optimization.
Spark guarantees not to have `scale < 0`
https://github.com/apache/spark/pull/26881
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
