masonh22 commented on PR #20051: URL: https://github.com/apache/datafusion/pull/20051#issuecomment-3824487263
> I am thinking about NULL support inside InList expressions for this simplification. I don't think InList supports distinct behavior like is distinct from or is not distinct from, so we should probably avoid it. Hmmm, I see that you are already checking whether the list contains null and not applying the rule in that case. I'm not really sure what the semantics are for null values in InList. I see that `ShortenInListSimplifier`, which rewrites InList expressions as `a == x || a == y ...` (or `a != x && a != y ...` if it's negated), doesn't check whether any of the values are null. So from that perspective, I think it would be fine to pass a null literal value into `get_preimage()`. Does that make sense? Is that what you were thinking about? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
