AndreaBozzo commented on PR #19916: URL: https://github.com/apache/datafusion/pull/19916#issuecomment-3822747137
Hi @Jefffrey, thanks for the feedback. I've updated the PR title and body to accurately reflect the current state of the changes after the `SchemaDisplay` revert. Given the scope creep of ~44 sqllogictest updates, 4 `datafusion-testing` submodule files needing a separate PR, and the known limitation with excessive parentheses on associative operators, i'm wondering whether this change is worth the churn on its own, or if it would be better to revisit this as part of a broader effort to handle parentheses consistently across all display modes. Happy to hear your thoughts on whether to proceed or hold off, and if its the second case, i apologize for wasting someone else time, the intent behind was genuine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
