alamb commented on code in PR #20019:
URL: https://github.com/apache/datafusion/pull/20019#discussion_r2743118471
##########
datafusion/physical-plan/src/aggregates/mod.rs:
##########
@@ -144,6 +144,23 @@ pub enum AggregateMode {
/// This mode requires that the input has more than one partition, and is
/// partitioned by group key (like FinalPartitioned).
SinglePartitioned,
+ /// Combine multiple partial aggregations to produce a new partial
+ /// aggregation.
+ ///
+ /// Input is intermediate accumulator state (like Final), but output is
+ /// also intermediate accumulator state (like Partial). This enables
+ /// tree-reduce aggregation strategies where partial results from
+ /// multiple workers are combined in multiple stages before a final
+ /// evaluation.
+ ///
+ /// ```text
+ /// Final
+ /// / \
+ /// PartialReduce PartialReduce
+ /// / \ / \
+ /// Partial Partial Partial Partial
+ /// ```
+ PartialReduce,
Review Comment:
I think this Partial Reduce mode makes sense
I find our other modes somewhat confusing (I am not sure why we have them
and suspect we could make this a much cleaner 2 mode switch like "initial",
"partial", and "final"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
