viirya commented on code in PR #613:
URL: https://github.com/apache/datafusion-comet/pull/613#discussion_r1672513653
##########
spark/src/test/scala/org/apache/spark/sql/CometTPCDSQuerySuite.scala:
##########
@@ -112,7 +108,9 @@ class CometTPCDSQuerySuite
"q69",
"q70",
"q71",
- "q72",
+ // TODO: unknown failure (seems memory usage over Github action
runner) in CI with q72 in
+ // https://github.com/apache/datafusion-comet/pull/613.
+ // "q72",
Review Comment:
> I am +1 on skipping running the official q72 query by default (because it
is so ridiculous), especially in CI. However, maybe we should consider running
an optimized version where the join order is sensible, which makes it at least
10x faster and uses far less memory. I will file a follow on issue to discuss
this.
Sounds good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
