Rachelint commented on code in PR #11319:
URL: https://github.com/apache/datafusion/pull/11319#discussion_r1667820117
##########
datafusion/core/src/datasource/physical_plan/parquet/statistics.rs:
##########
@@ -747,10 +770,10 @@ macro_rules! get_data_page_statistics {
Some(DataType::Boolean) => Ok(Arc::new(
BooleanArray::from_iter(
Review Comment:
> We could use BooleanBuilder instead? That would likely be more efficient.
Seems reasonable! Maybe it can work to remove the `collect` in
`BooleanArray` case, I try it soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
