rtyler commented on code in PR #11180:
URL: https://github.com/apache/datafusion/pull/11180#discussion_r1667729599
##########
datafusion/sql/src/expr/mod.rs:
##########
@@ -341,7 +278,17 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
}
};
- self.plan_field_access(expr, get_field_access)
+ let mut field_access_expr = RawFieldAccessExpr { expr,
field_access };
+ for planner in self.planners.iter() {
+ match planner.plan_field_access(field_access_expr,
schema)? {
+ PlannerResult::Planned(expr) => return Ok(expr),
+ PlannerResult::Original(expr) => {
+ field_access_expr = expr;
+ }
+ }
+ }
+
+ not_impl_err!("GetFieldAccess not supported by
UserDefinedExtensionPlanners: {field_access_expr:?}")
Review Comment:
:wave: I'm curious about this default branch because I'm seeing this error
when doing integration testing with the delta-rs package. To the best of my
knowledge we're not using any extension planners, but now [this is
failing](https://github.com/delta-io/delta-rs/blob/main/crates/core/src/operations/delete.rs#L769-L773)
with the latest datafusion. I'm uncertain whether we're doing something
wrong, or if the default behavior of falling through to `not_impl_err` is
causing us grief
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
