alamb commented on code in PR #11180:
URL: https://github.com/apache/datafusion/pull/11180#discussion_r1661062684
##########
datafusion/expr/src/planner.rs:
##########
@@ -114,8 +114,12 @@ pub trait UserDefinedSQLPlanner {
/// An operator with two arguments to plan
///
-/// Note `left` and `right` are DataFusion [`Expr`]s but the `op` is the SQL
AST operator.
-/// This structure is used by [`UserDefinedSQLPlanner`] to plan operators with
custom expressions.
+/// Note `left` and `right` are DataFusion [`Expr`]s but the `op` is the SQL
AST
+/// operator.
+///
+/// This structure is used by [`UserDefinedSQLPlanner`] to plan operators with
+/// custom expressions.
+#[derive(Debug, Clone)]
Review Comment:
I agree there isn't a critical usecase for it now, but I figured it didn't
hurt. If you feel strongly I will remove `Clone`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
