xinlifoobar commented on code in PR #11266:
URL: https://github.com/apache/datafusion/pull/11266#discussion_r1666132979
##########
datafusion/physical-plan/src/filter.rs:
##########
@@ -357,9 +370,23 @@ pub(crate) fn batch_filter(
.evaluate(batch)
.and_then(|v| v.into_array(batch.num_rows()))
.and_then(|array| {
- Ok(as_boolean_array(&array)?)
- // apply filter array to record batch
- .and_then(|filter_array| Ok(filter_record_batch(batch,
filter_array)?))
+ let filter_array = match as_boolean_array(&array) {
+ Ok(boolean_array) => {
+ Ok(boolean_array.to_owned())
+ },
+ Err(_) => {
+ let Ok(null_array) = as_null_array(&array) else {
+ return internal_err!("Cannot create filter_array from
non-boolean predicates, unable to continute");
Review Comment:
In the previous it will throw a downcast_error, which mess up the debugging
logs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
