ozankabak commented on code in PR #11203:
URL: https://github.com/apache/datafusion/pull/11203#discussion_r1662625529
##########
datafusion/optimizer/src/push_down_filter.rs:
##########
@@ -441,11 +442,11 @@ fn push_down_all_join(
// Extract from OR clause, generate new predicates for both side of join
if possible.
// We only track the unpushable predicates above.
- if left_preserved {
+ if on_left_preserved {
left_push.extend(extract_or_clauses_for_join(&keep_predicates,
left_schema));
left_push.extend(extract_or_clauses_for_join(&join_conditions,
left_schema));
}
- if right_preserved {
+ if on_right_preserved {
Review Comment:
I think we found one example -- @mustafasrepo will post shortly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
