parthchandra commented on code in PR #577:
URL: https://github.com/apache/datafusion-comet/pull/577#discussion_r1643450317
##########
spark/inspections/CometTPCHQueriesList-results.txt:
##########
@@ -1,133 +1,133 @@
-Query: q1 TPCH Snappy. Comet Exec: Enabled (CometHashAggregate, CometProject)
+Query: q1 TPCH Snappy. Comet Exec: Enabled (CometHashAggregate, CometFilter,
CometProject)
Query: q1 TPCH Snappy: ExplainInfo:
Comet shuffle is not enabled: spark.sql.adaptive.coalescePartitions.enabled is
enabled and spark.comet.shuffle.enforceMode.enabled is not enabled
Query: q2 TPCH Snappy. Comet Exec: Enabled (CometFilter, CometProject)
Query: q2 TPCH Snappy: ExplainInfo:
-BroadcastExchange is not supported
+BroadcastHashJoin is not enabled because not all child plans are native
Review Comment:
This would be a lot more readable if the information was nested. For
instance something like -
```
BroadcastHashJoin is not enabled because the following children are not
native (Project, BroadcastExchange)
-- Project is not native because the following children are not native
(BroadcastHashJoin)
-- BroadcastHashJoin is not enabled because the following children are
not native (BroadcastExchange)
-- etc
```
But then we would defeat our first goal because the output would become
query specific
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
