eejbyfeldt opened a new pull request, #543:
URL: https://github.com/apache/datafusion-comet/pull/543
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Resolves issue discovered in #481 .
## Rationale for this change
Datafusion and coment uses `chrono::Datetime` for many of it datetime needs.
This leads to some problems as the possible date representable by
`chrono::Datetime` is smaller then the value representable by a i64 microsecond
timestamp. This means that we currently fail and/or return different results
from Spark. On of these cases was in the method `pre_timestamp_cast` that
currently panics if operating on a value not representable by
`chrono::Datetime`.
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
## What changes are included in this PR?
This change the code so that instead of a panic the code returns an error
message to the user explaining what went wrong.
`
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
## How are these changes tested?
New and existing unit tests.
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
