kazuyukitanimura commented on code in PR #539:
URL: https://github.com/apache/datafusion-comet/pull/539#discussion_r1631608977
##########
spark/src/main/spark-4.0/org/apache/comet/shims/CometExprShim.scala:
##########
@@ -27,7 +28,19 @@ trait CometExprShim {
/**
* Returns a tuple of expressions for the `unhex` function.
*/
- protected def unhexSerde(unhex: Unhex): (Expression, Expression) = {
+ def unhexSerde(unhex: Unhex): (Expression, Expression) = {
(unhex.child, Literal(unhex.failOnError))
}
+
+ def evalMode(c: Cast): CometEvalMode.Value =
+ CometEvalModeUtil.fromSparkEvalMode(c.evalMode)
Review Comment:
nit: it seems to be that we can keep it as `protected` instead of changing
to public?
Also `evalMode` can be `protected`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
