marvinlanhenke commented on code in PR #10801:
URL: https://github.com/apache/datafusion/pull/10801#discussion_r1628177847
##########
datafusion/core/src/datasource/physical_plan/parquet/statistics.rs:
##########
@@ -256,6 +259,13 @@ macro_rules! get_statistic {
Some(DataType::Float16) => {
Some(ScalarValue::Float16(from_bytes_to_f16(s.$bytes_func())))
}
+ Some(DataType::Interval(unit)) => {
+ match unit {
+ IntervalUnit::YearMonth =>
unimplemented!("Interval statistics not yet supported by parquet"),
Review Comment:
in this case we never reach the match arm, since
> in general, in rust `unimplemented!()` results in a panic which is not a
great user experience.
>
> I think this code purposely ignores errors (in order to gracefully handle
parquet files that might not have the expected statistics or that were created
from some other writer)
>
> Thus, I suggest changing these cases from `panic` to `None` (and then
adjusting the test appropriately)
>
> If we return `None`, once statistics are properly stored by the parquet-rs
writer, the test will fail on next upgrade and we can update the test with the
correct values
Yes, I see with the merge of #10711 the match arms changed; so I'll take a
look at that and adjust accordingly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
