goldmedal commented on code in PR #10745:
URL: https://github.com/apache/datafusion/pull/10745#discussion_r1624740586
##########
datafusion/core/Cargo.toml:
##########
@@ -158,6 +159,16 @@ tokio-postgres = "0.7.7"
[target.'cfg(not(target_os = "windows"))'.dev-dependencies]
nix = { version = "0.29.0", features = ["fs"] }
+[target.'cfg(not(target_arch = "wasm32"))'.dependencies]
+aws-config = "0.101.0"
+aws-credential-types = "0.101.0"
+# the default features will cause libunwind error when testing on macos
paltform.
+object_store = { version = "0.9.1", default-features = false, features =
["aws", "gcp", "http"] }
Review Comment:
Actually, I don't know which default feature causes the error on macOS. I
just used trial and error many times, and eventually, it worked. I noticed that
we disabled the default features in the root Cargo.toml by #8095, but I can't
find the reason. Could someone explain this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
