andygrove commented on code in PR #10702: URL: https://github.com/apache/datafusion/pull/10702#discussion_r1620865281
########## datafusion/core/src/physical_optimizer/join_selection.rs: ########## @@ -157,7 +157,9 @@ fn swap_join_projection( } /// This function swaps the inputs of the given join operator. -fn swap_hash_join( +/// This function is public so other downstream projects can use it +/// to construct `HashJoinExec` with right side as the build side. Review Comment: I think there is a benefit in leaving the documentation that explains the rationale for why this is public -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
