berkaysynnada commented on code in PR #10600:
URL: https://github.com/apache/datafusion/pull/10600#discussion_r1620399285
##########
datafusion/core/src/datasource/stream.rs:
##########
@@ -103,19 +105,46 @@ impl FromStr for StreamEncoding {
}
}
-/// The configuration for a [`StreamTable`]
+/// The StreamProvider trait is used as a generic interface for reading and
writing from streaming
+/// data sources (such as FIFO, Websocket, Kafka, etc.). Implementations of
the provider are
+/// responsible for providing a `RecordBatchReader` and optionally a
`RecordBatchWriter`.
+pub trait StreamProvider: std::fmt::Debug + Send + Sync {
Review Comment:
I am not sure people associate location with 'Format'. FileFormat does not
deal with location. I think StreamProvider is descriptive enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
