andygrove commented on code in PR #437:
URL: https://github.com/apache/datafusion-comet/pull/437#discussion_r1619362298
##########
core/src/execution/datafusion/planner.rs:
##########
@@ -978,7 +979,15 @@ impl PhysicalPlanner {
// `EqualNullSafe`, Spark will rewrite it during planning.
false,
)?);
- Ok((scans, join))
+
+ // If the hash join is build right, we need to swap the left
and right
+ let hash_join = if join.build_side == 0 {
Review Comment:
nit: we can use the generated enum from the proto here to reference
`BuildLeft` rather than `0`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
