alamb commented on code in PR #10621:
URL: https://github.com/apache/datafusion/pull/10621#discussion_r1609979618


##########
datafusion-cli/src/catalog.rs:
##########
@@ -192,7 +192,7 @@ impl SchemaProvider for DynamicFileSchemaProvider {
                     &state.default_table_options(),
                 )
                 .await?;
-                state.runtime_env().register_object_store(url, store);
+                state.register_object_store(url, store);

Review Comment:
   the point of this PR is to avoid having to do `runtime_env()`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to