erratic-pattern commented on code in PR #10473:
URL: https://github.com/apache/datafusion/pull/10473#discussion_r1604227125
##########
datafusion/expr/src/expr.rs:
##########
@@ -1389,6 +1390,201 @@ impl Expr {
| Expr::Placeholder(..) => false,
}
}
+
+ pub fn hash_node(&self, hasher: &mut AHasher) {
Review Comment:
what's the benefit of this vs using the derived `Hash` impl. I think a
comment explaining the differences might be useful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
