erratic-pattern commented on code in PR #10473:
URL: https://github.com/apache/datafusion/pull/10473#discussion_r1604224615


##########
datafusion/expr/src/expr.rs:
##########
@@ -1389,6 +1390,201 @@ impl Expr {
             | Expr::Placeholder(..) => false,
         }
     }
+
+    pub fn hash_node(&self, hasher: &mut AHasher) {
+        match self {
+            Expr::Alias(Alias { relation, name, .. }) => {
+                hasher.write_u8(0);

Review Comment:
   would it be easier to use 
[`std::mem::discriminant`](https://doc.rust-lang.org/std/mem/fn.discriminant.html)?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to