kazuyukitanimura commented on code in PR #412:
URL: https://github.com/apache/datafusion-comet/pull/412#discussion_r1597246287
##########
spark/src/main/spark-3.x/org/apache/comet/shims/ShimCometScanExec.scala:
##########
@@ -69,6 +69,8 @@ trait ShimCometScanExec {
readSchema: StructType,
options: ParquetOptions): FileScanRDD =
classOf[FileScanRDD].getDeclaredConstructors
+ // workaround for aws spark 3.4 implementation
+ .filter(c => List(3,5,6).contains(c.getParameterCount()) )
Review Comment:
I am fine with the current workaround, but we can potentially move this
function to `spark-3.2`, `spark-3.3`, and `spark-3.4` then remove the
reflection. Then type check should work...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
