alamb commented on code in PR #10394:
URL: https://github.com/apache/datafusion/pull/10394#discussion_r1592832784
##########
datafusion/sqllogictest/test_files/aggregate.slt:
##########
@@ -3260,7 +3260,7 @@ SELECT STRING_AGG(column1, '|') FROM (values (''),
(null), (''));
statement ok
CREATE TABLE strings(g INTEGER, x VARCHAR, y VARCHAR)
-query ITT
+query I
Review Comment:
👍
##########
datafusion/core/tests/sql/sql_api.rs:
##########
@@ -58,6 +58,19 @@ async fn unsupported_dml_returns_error() {
ctx.sql_with_options(sql, options).await.unwrap();
}
+#[tokio::test]
Review Comment:
I think keeping the rust level test is a good idea as it makes explicit the
expected output schema
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
