leoyvens commented on code in PR #10394:
URL: https://github.com/apache/datafusion/pull/10394#discussion_r1591377689
##########
datafusion/core/tests/sql/sql_api.rs:
##########
@@ -58,6 +58,19 @@ async fn unsupported_dml_returns_error() {
ctx.sql_with_options(sql, options).await.unwrap();
}
+#[tokio::test]
Review Comment:
Curiously, this was in fact tested in many sqllogictests. Because the tests
do in fact cover checking that the physical output schema matches the logical
output schema, which is pretty cool.
Let me know if you want to keep this Rust test as well, or if you rather
that I remove it. It does test more behaviour than what the slts can test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
