jayzhan211 commented on code in PR #10391:
URL: https://github.com/apache/datafusion/pull/10391#discussion_r1590941453
##########
datafusion/expr/src/udaf.rs:
##########
@@ -309,19 +302,10 @@ pub trait AggregateUDFImpl: Debug + Send + Sync {
/// The name of the fields must be unique within the query and thus should
/// be derived from `name`. See [`format_state_name`] for a utility
function
/// to generate a unique name.
- fn state_fields(
- &self,
- name: &str,
- value_type: DataType,
- ordering_fields: Vec<Field>,
- ) -> Result<Vec<Field>> {
- let value_fields = vec![Field::new(
- format_state_name(name, "value"),
- value_type,
- true,
- )];
-
- Ok(value_fields.into_iter().chain(ordering_fields).collect())
+ ///
+ /// [`format_state_name`]: crate::utils::format_state_name
+ fn state_fields(&self, _args: StateFieldsArgs) -> Result<Vec<Field>> {
+ not_impl_err!("state_fields hasn't been implemented for {self:?} yet")
Review Comment:
I found most of the `state_fields` have their own version, so return err if
not defined now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
