jayzhan211 commented on issue #10074: URL: https://github.com/apache/datafusion/issues/10074#issuecomment-2082240499
How about we introduce physical aggregate function trait, `AggregateUDFPhysicalImpl` I expect that `AggregateUDFPhysicalImpl` handle the physical-expr, for example, `accumulator` and `reverse_expr`. We create logical aggregate and handle optimization in logical layer. Create physical aggregate via `create_physical_expr`. Once we created, we never need to deal with logical-expr and physical-expr conversion. For `reverse_expr`, we just create another physical-expr that implement `AggregateUDFPhysicalImpl`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
