kavirajk commented on PR #10153: URL: https://github.com/apache/datafusion/pull/10153#issuecomment-2081525001
@alamb thanks for the suggestion 👍 . Quick follow up. That command you mentioned `sqllogictests --complete` only updates the `.slt` files that are part of `datafusion/sqllogictest` crate itself. I don't see it updates any of the other test cases where we are asserting the physical plan string representation. That still needs manual updates correct (around 79 tests were failing)?. I started updating those, just wanted to check if there are any easy/automated way that I'm not aware of it :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
