duongcongtoai commented on issue #10207: URL: https://github.com/apache/datafusion/issues/10207#issuecomment-2081408842
1st item: ``` create table t (s struct(n int, s varchar)) ``` I think upstream sqlparser lib already support similar syntax ``` create table t (s struct<n int, s varchar>); ``` But only bigquery dialect support this syntax. However in this PR where [struct syntax is is added](https://github.com/sqlparser-rs/sqlparser-rs/pull/1003#discussion_r1369976422) they also decided to support this syntax for both Bigquery and GenericDialect, and i think they forgot to add | GenericDialect for the column definition parsing logic here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
