aIbrahiim commented on code in PR #37725: URL: https://github.com/apache/beam/pull/37725#discussion_r2882686469
########## sdks/python/apache_beam/ml/transforms/embeddings/vertex_ai_test.py: ########## @@ -20,10 +20,13 @@ import unittest import uuid +import pytest + import apache_beam as beam from apache_beam.ml.inference.base import RunInference from apache_beam.ml.transforms import base from apache_beam.ml.transforms.base import MLTransform +from apache_beam.testing.vertex_ai_skip import skip_if_vertex_ai_disabled Review Comment: i created skip_if_vertex_ai_disabled as a check for if vertex AI dependencies available in one place (vertex_ai_skip.py) so i dont have to repeat similar import and try/except checks in every vertex test file but the local imports around line 40 are still needed for the test logic itself but the decorator let us keep the skip condition shared -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
