aIbrahiim commented on code in PR #37725:
URL: https://github.com/apache/beam/pull/37725#discussion_r2882673090
##########
sdks/python/apache_beam/ml/rag/embeddings/vertex_ai_test.py:
##########
@@ -58,6 +61,8 @@ def chunk_approximately_equals(expected, actual):
all(isinstance(x, float) for x in actual.embedding.dense_embedding))
+@skip_if_vertex_ai_disabled
Review Comment:
ahh right that i already gate on VERTEX_AI_AVAILABLE via the local
unittest.skipIf, so the decorator doesnt add new behavior there it was meant to
align all vertex AI tests on a shared helper but in this specific file it is
redundant so i will drop @skip_if_vertex_ai_disabled here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
