thomasrebele commented on PR #6276:
URL: https://github.com/apache/hive/pull/6276#issuecomment-3884899781

   It seems that removing the field is more difficult than expected. I had 
tried to remove it, but that leads to some ClassCastException, and the stats do 
not appear when using the DESCRIBE FORMATTED command.
   
   @kasakrisz, how would the setting be passed to the factory? Where would the 
factory/singleton live? Would your suggestion pass some kind of `StatsFactory 
factory` parameter instead of the timestamp parameter through the call stack?
   
   Alternatively, to make the approach extensible, while keeping it close to 
the original code, a new class ColumnStatsConf could be passed instead of the 
`timestampAsLong` parameter. If necessary, more configuration options could be 
added to that class.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to