kasakrisz commented on PR #6276: URL: https://github.com/apache/hive/pull/6276#issuecomment-3841603608
@thomasrebele The idea that the patch tries to implement looks good to me, but I have some architectural concerns: I noticed that the parameter `timestampAsLong` is passed through several levels of the call stack. This could be avoided by using a singleton approach for stats conversion instead of static methods, since more than one implementation could be provided—one for storing the timestamp as-is and another for storing it as a Long. The factory method of the singleton instance could choose the implementation based on the new setting. Alternatively, we could ask around on the Hive user/dev mailing lists whether HIVE-22311 can be reverted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
