dengzhhu653 commented on code in PR #6287:
URL: https://github.com/apache/hive/pull/6287#discussion_r2776760035
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java:
##########
@@ -1361,40 +1169,7 @@ public void create_database_req(final
CreateDatabaseRequest createDatabaseReques
} catch (NoSuchObjectException e) {
// expected
}
-
- Database db = new Database(createDatabaseRequest.getDatabaseName(),
createDatabaseRequest.getDescription(),
- createDatabaseRequest.getLocationUri()
,createDatabaseRequest.getParameters());
- if (createDatabaseRequest.isSetPrivileges()) {
- db.setPrivileges(createDatabaseRequest.getPrivileges());
- }
- if (createDatabaseRequest.isSetOwnerName()) {
- db.setOwnerName(createDatabaseRequest.getOwnerName());
- }
- if (createDatabaseRequest.isSetOwnerType()) {
- db.setOwnerType(createDatabaseRequest.getOwnerType());
- }
- db.setCatalogName(createDatabaseRequest.getCatalogName());
- if (createDatabaseRequest.isSetCreateTime()) {
- db.setCreateTime(createDatabaseRequest.getCreateTime());
- } else {
- db.setCreateTime((int)(System.currentTimeMillis() / 1000));
- }
- if (createDatabaseRequest.isSetManagedLocationUri()) {
-
db.setManagedLocationUri(createDatabaseRequest.getManagedLocationUri());
- }
- if (createDatabaseRequest.isSetType()) {
- db.setType(createDatabaseRequest.getType());
- }
- if (createDatabaseRequest.isSetDataConnectorName()) {
- db.setConnector_name(createDatabaseRequest.getDataConnectorName());
- }
- if (createDatabaseRequest.isSetRemote_dbname()) {
- db.setRemote_dbname(createDatabaseRequest.getRemote_dbname());
- }
- create_database_core(getMS(), db);
- createDatabaseRequest.setLocationUri(db.getLocationUri());
- createDatabaseRequest.setManagedLocationUri(db.getManagedLocationUri());
- success = true;
+ success = AbstractRequestHandler.offer(this,
createDatabaseRequest).success();
} catch (Exception e) {
Review Comment:
the create_database returns `void`, so if a user want to get the database
after created, he needs to issue a new get database call instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
