dengzhhu653 commented on code in PR #6287:
URL: https://github.com/apache/hive/pull/6287#discussion_r2776615376
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java:
##########
@@ -918,11 +910,12 @@ public void create_catalog(CreateCatalogRequest rqst)
ms.createCatalog(catalog);
// Create a default database inside the catalog
- Database db = new Database(DEFAULT_DATABASE_NAME,
- "Default database for catalog " + catalog.getName(),
catalog.getLocationUri(),
- Collections.emptyMap());
- db.setCatalogName(catalog.getName());
- create_database_core(ms, db);
+ CreateDatabaseRequest cdr = new
CreateDatabaseRequest(DEFAULT_DATABASE_NAME);
+ cdr.setCatalogName(catalog.getName());
+ cdr.setLocationUri(catalog.getLocationUri());
+ cdr.setParameters(Collections.emptyMap());
+ cdr.setDescription("Default database for catalog " +
catalog.getName());
+ AbstractRequestHandler.offer(this, cdr).getResult();
Review Comment:
` AbstractRequestHandler.offer(this, cdr).getResult();` happens in the same
thread as the create_catalog
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
