tarak271 commented on code in PR #5087:
URL: https://github.com/apache/hive/pull/5087#discussion_r1496805265
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/misc/msck/MsckOperation.java:
##########
@@ -75,9 +76,9 @@ public int execute() throws HiveException, IOException,
TException {
desc.getFilterExp(), desc.getResFile(), desc.isRepairPartitions(),
desc.isAddPartitions(), desc.isDropPartitions(),
partitionExpirySeconds);
return msck.repair(msckInfo);
- } catch (MetaException e) {
+ } catch (MetaException | MetastoreException e) {
LOG.error("Unable to create msck instance.", e);
- return 1;
+ throw e;
} catch (SemanticException e) {
Review Comment:
Yes. Added test case msck_repair_8.q to see how semantic exception is handled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
