zhangbutao commented on code in PR #5087:
URL: https://github.com/apache/hive/pull/5087#discussion_r1494729066
##########
ql/src/test/results/clientnegative/msck_repair_1.q.out:
##########
@@ -21,4 +21,4 @@ POSTHOOK: Output: default@repairtable
PREHOOK: query: MSCK TABLE default.repairtable
PREHOOK: type: MSCK
PREHOOK: Output: default@repairtable
-FAILED: Execution Error, return code 1 from
org.apache.hadoop.hive.ql.ddl.DDLTask
+#### A masked pattern was here ####
Review Comment:
What's the real execption here?
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/misc/msck/MsckOperation.java:
##########
@@ -75,9 +76,9 @@ public int execute() throws HiveException, IOException,
TException {
desc.getFilterExp(), desc.getResFile(), desc.isRepairPartitions(),
desc.isAddPartitions(), desc.isDropPartitions(),
partitionExpirySeconds);
return msck.repair(msckInfo);
- } catch (MetaException e) {
+ } catch (MetaException | MetastoreException e) {
LOG.error("Unable to create msck instance.", e);
- return 1;
+ throw e;
} catch (SemanticException e) {
Review Comment:
Will client get the detail error information in case of `SemanticException`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
