Junio C Hamano <gits...@pobox.com> writes:
>> + if test -n "$deinit_all" && test "$#" -ne 0
>> + then
>> + die "$(eval_gettext "usage: $dashless [--quiet] deinit
>> [-f|--force] (--all | [--] <path>...)")"
>
> I doubt that "usage:" wants to go thru l10n.
>
> I suspect that it is more friendly to the user to say that in prose,
> i.e.e.g. "--all and pathspec cannot be given at the same time", than
> forcing them to grok the (alternative|possibilities).
>
>> + fi
>> + if test $# = 0 && test -z "$deinit_all"
>> then
>> - die "$(eval_gettext "Use '.' if you really want to deinitialize
>> all submodules")"
>> + die "$(eval_gettext "Use '--all' if you really want to
>> deinitialize all submodules")"
>> fi
>
> This is good.
By the way, while it is a very good idea to die upon
$ git submodule deinit --all no-only-this-one
it may not be too bad if we demoted the output to "info" with clean
no-op exit when the user said
$ git submodule deinit
IOW, the latter part _might_ be better if it were
if test $# = 0 && test -z "$deinit_all"
then
echo >&2 "info: not deinitializing anything."
echo >&2 "info: Use --all to deinitialize all submodules."
exit 0
fi
given that this is really about preventing mistakes from doing mass
destruction.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
