On Tue, Feb 16, 2016 at 04:46:07PM +0000, Ramsay Jones wrote: > > OK, I am happy to add the extra code. > > Unless I've missed something (quite possible), this patch does not > need to change. (you have (both) convinced me that your current > solution is the best). > > The only change that I would suggest is the one-liner I already > suggested to the previous patch (plus the one-liner in the test, > of course. err ... so the two-liner!). Having said that, I didn't > try it out - I was just typing into my email client, so ...
I think it's more than that one-liner. This patch shows "type:name" verbatim from what is passed into do_config_from_file, as does the error message. If they are going to have different output formats (e.g., "<stdin>" versus "stdin"), there needs to be logic transforming them in at least one of the spots. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
