On 01/28, Stefan Beller wrote: > On Thu, Jan 28, 2016 at 12:36 PM, Matthias Asshauer <mha1...@live.de> wrote: > > From: Matthias Aßhauer <mha1...@live.de> > > > > Use the new "git stash--helper" builtin. It should be faster than the old > > shell code and is a first step to move > > more shell code to C. > > You had some good measurements in the coverletter, which is not going to be > recorded in the projects history. This part however would be part of the > commit. > So you could move the speed improvements here (as well as the other reasoning) > on why this is a good idea. :)
In addition it would be nice to add a performance test in t/perf, especially since it seems further improvements are planned. That will make it easy for everyone to reproduce the performance numbers for different use-cases. Matthias, feel free to squash the following (or something similar) in when you re-roll. diff --git a/t/perf/p3000-stash.sh b/t/perf/p3000-stash.sh new file mode 100755 index 0000000..e6e1153 --- /dev/null +++ b/t/perf/p3000-stash.sh @@ -0,0 +1,20 @@ +#!/bin/sh + +test_description="Test performance of git stash" + +. ./perf-lib.sh + +test_perf_default_repo + +file=$(git ls-files | tail -n 30 | head -1) + +test_expect_success "prepare repository" " + echo x >$file +" + +test_perf "stash/stash pop" " + git stash && + git stash pop +" + +test_done -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
