Paul Smith <p...@mad-scientist.net> writes: >> Why these changes? I thought you are making sure $cleandir is >> absolute so that you do not have to do this and can just "cd" into >> the new working tree, the same way the user would do once it is set >> up. > > I made cleandir absolute mainly because you asked me to :-). I didn't > realize that the implication behind that request was that I'd put back > the original "cd" as well.
This is about not changing unnecessarily the original that has been battle-tested and keeping the result resistant to future mistakes (i.e. somebody going elsewhere without realizing a relative cleandir will cause problems). Once $cleandir is fixed, there no longer is a good reason to change how HEAD is pointed in the $new_workdir or its working tree populated; the change in the earlier round in that area was necessary when $cleandir was not absolute, but not anymore. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
