On Thu, Nov 20, 2014 at 1:20 PM, Jonathan Nieder <jrnie...@gmail.com> wrote: >> >> For now the new function is only used from log_ref_write, but later >> on we will call this function from reflog transactions too. That means >> that we will end up with only a single place, where we write a >> reflog entry to a file instead of the current two places >> (log_ref_write and builtin/reflog.c). > > Line-wrapping width is still inconsistent. I don't think it's worth > resending just for that, but something to look out for in the future. >
ok, I'll care about that more in the future. > I don't understand why the above writes to a temporary variable and > checks it, never to read that temporary again. > > I don't think that alone is a reason to block the patch, but it > worries me in that the review comment seems to have been just lost. It wasn't lost as I think it should go in a follow up patch. Sorry for not stating that clearly. (This patch is about moving code around, not changing code) I got interrupted preparing the follow up patch, which gets rid of the temporary variable. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
