James Denholm <nod.h...@gmail.com> writes: > contrib/subtree/Makefile is a shambles in regards to it's consistency > with other makefiles, which makes subtree overly painful to include in > build scripts. > > The main issues are that calls are made to git itself in the build > process, and that a subtree-exclusive variable is used for specifying > the exec path. Patches 1/5 through 3/5 resolve these. > > The "cleanup" fixes (4/5 and 5/5) are based on precedents set by other > makefiles across the project. > > One problem is foreseen: 3/5 will necessitate that package maintainers > who already have git-subtree included in their packages update their > build-scripts. > > Reviewed-by: Jeff King <p...@peff.net> > Signed-off-by: James Denholm <nod.h...@gmail.com> > Based-on-patch-by: Dan McGee <dpmc...@gmail.com>
It is funny to see sign-off on 0/5 ;-) By the way, this is v3, not v2, no? It was somewhat confusing to see Peff saying "filfre to add my reviewed-by" on v2, noticing you posted something new, and not finding v3. Will queue. Thanks. > > James Denholm (5): > contrib/subtree/Makefile: scrap unused $(gitdir) > contrib/subtree/Makefile: Use GIT-VERSION-FILE > contrib/subtree/Makefile: s/libexecdir/gitexecdir > contrib/subtree/Makefile: Doc-gen rules cleanup > contrib/subtree/Makefile: clean rule cleanup > > contrib/subtree/Makefile | 38 +++++++++++++++++++++++--------------- > 1 file changed, 23 insertions(+), 15 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
