John Keeping <j...@keeping.me.uk> writes:
> +relative_path ()
> +{
> + local target curdir result
> + target=$1
> + curdir=${2-$wt_prefix}
> + curdir=${curdir%/}
> + result=
> +
> + while test -n "$curdir"
> + do
> + case "$target" in
> + "$curdir/"*)
> + target=${target#$curdir/}
> + break
> + ;;
> + esac
Could $curdir have glob wildcard to throw this part of the logic
off? It is OK to have limitations like "you cannot have a glob
characters in your path to submodule working tree" (at least until
we start rewriting these in C or Perl or Python), but we need to be
aware of them.
> module_list()
> {
> + eval "set $(git rev-parse --sq --prefix "$wt_prefix" -- "$@")"
An efficient reuse of "--" ;-)
> +test_expect_success 'run summary from subdir' '
> + mkdir sub &&
> + (
> + cd sub &&
> + git submodule summary >../actual
> + ) &&
> + cat >expected <<-EOF &&
> +* ../sm1 0000000...$head1 (2):
> + > Add foo2
> +
> +EOF
It somewhat looks strange to start with "<<-EOF" and then not to
indent the body nor EOF.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
