Phillip Wood <phillip.wood...@gmail.com> writes:

>> Firstly, signature of `create_seq_dir` doesn't allow us to call
>> `sequencer_get_last_command()`. Changing that for the sake of a
>> better error message is too much task for this patch as it is a
>> subject of discussion on its own.
>
> There is only one caller and it already has a struct repository pointer
> so it is a two line change, one of which is the insertion of a single
> character to change create_seq_dir() so it can call
> sequencer_get_last_command(). It is normal to change function signatures
> (especially for static functions like this) when making changes, it is
> part of improving the code base. The quality of error messages is
> important to the overall user experience. It's when things go wrong that
> users need accurate advice about what to do.

Thanks for guiding a new contributor in the right direction gently.
Very much appreciated.

Reply via email to