Hi Peff,
On Thu, 7 Mar 2019, Jeff King wrote:
> On Mon, Feb 25, 2019 at 11:16:22PM +0000, Thomas Gummerer wrote:
>
> > +static void add_pathspecs(struct argv_array *args,
> > + struct pathspec ps) {
>
> Here and elsewhere in the series, I notice that we pass the pathspec
> struct by value, which is quite unusual for our codebase (and
> potentially confusing, if any of the callers were to mutate the pointers
> in the struct).
>
> Is there any reason this shouldn't be "const struct pathspec *ps" pretty
> much throughout the file?
I am quite certain that this is merely an oversight. It totes slipped
by my review, for example.
Thanks for catching!
Dscho
