On February 18, 2019 15:50, Max Kirillov wrote:
> To: SZEDER Gábor <szeder....@gmail.com>; git@vger.kernel.org
> Cc: Max Kirillov <m...@max630.net>; Johannes Schindelin
> <johannes.schinde...@gmx.de>; Randall S. Becker
> <rsbec...@nexbridge.com>; 'Junio C Hamano' <gits...@pobox.com>
> Subject: [PATCH] t5562: chunked sleep to avoid lost SIGCHILD
>
> If was found during stress-test run that a test may hang by 60 seconds.
> It supposedly happens because SIGCHILD was received before sleep has
> started.
>
> Fix by looping by smaller chunks, checking $exited after each of them.
> Then lost SIGCHILD would not cause longer delay than 1 second.
>
> Reported-by: SZEDER Gábor <szeder....@gmail.com>
> Signed-off-by: Max Kirillov <m...@max630.net>
> ---
> Submitting as proper patch. Note: I believe it does not relate to other issues
> discussed in this thread.
> t/t5562/invoke-with-content-length.pl | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/t/t5562/invoke-with-content-length.pl b/t/t5562/invoke-with-
> content-length.pl
> index 0943474af2..257e280e3b 100644
> --- a/t/t5562/invoke-with-content-length.pl
> +++ b/t/t5562/invoke-with-content-length.pl
> @@ -29,7 +29,12 @@
> }
> print $out $body_data or die "Cannot write data: $!";
>
> -sleep 60; # is interrupted by SIGCHLD
> +my $counter = 0;
> +while (not $exited and $counter < 60) {
> + sleep 1;
> + $counter = $counter + 1;
> +}
> +
> if (!$exited) {
> close($out);
> die "Command did not exit after reading whole body";
I tried this fix and it made no difference to the hang on NonStop. I do not
think this fixes the root cause as sleep was never an issue and SIGCHLD was not
missed in any test I conducted. Maybe on another platform it is required.
