John Keeping <j...@keeping.me.uk> writes: >> + printf "%s%s\n" "$per_line_prefix" "$tool" > > This needs to be: > > printf "$per_line_prefix%s\n" "$tool" > > since $per_line_prefix is usually '\t\t' which isn't expanded if we > format it with %s - an alternative would be to change the value passed > in to '$TAB$TAB' with literal tabs.
I would prefer the latter, actually. I do understand the convenience of being able to write backslash-t, but I do not think it outweighs the potential risk of mistakingly passing a string with per-cent in it. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html