On Fri, Oct 26, 2018 at 08:43:37AM +0900, Junio C Hamano wrote:
> Jeff King <[email protected]> writes:
>
> > An easy test is:
> >
> > $ git rev-list --no-walk --exclude='*' --all --all
> > 3289ca716320457af5d2dd550b716282ad22da11
> > ...a bunch of other tip commits...
> >
> > $ git rev-parse --exclude='*' --all --all
> > [no output, but it should print those same tip commits]
>
> I actually was hoping to see a test that contrasts "--all" (which
> lacks the alleged "clear exclude" bug) with another option that does
> have the "clear exclude", both used with rev-parse, i.e.
>
> $ git rev-parse --exclude='*' --glob='*' --glob='*'
> ... all the ref tips ...
> $ git rev-parse --exclude='*' --all --all
> ... ought to be equivalent, but is empty due to the bug ...
>
> would have been a good demonstration that shows what bug we are
> fixing d(and would have been a good test to accompany the patch.
Yeah, I agree that would be fine, too. I think there are two dimensions
in which to look at the problem, like so:
rev-list rev-parse
-------- ---------
--glob clears clears
--all clears does not clear
Testing either the row or the column (or both) works for me. :)
-Peff
