Andreas Gruenbacher <agrue...@redhat.com> writes: >> All other glob options do show_reference with for_each_ref_in() and >> then calls clear_ref_exclusion(), and logically the patch makes >> sense. >> >> What is the "problem" this patch fixes, though? Is it easy to add a >> new test to t/6018-rev-list-glob.sh to demonstrate that "--glob" (or >> whatever that clears exclusion list without this patch) works >> correctly but "--all" misbehaves without this change? > > The test suite doesn't cover clearing the exclusion list for any of > those rev-parse options and I also didn't write such a test case. I > ran into this inconsistency during code review.
That is why I asked what "problem" this patch fixes. Without answering that question, it is unclear if the patch is completing missing coverage for "--all", or it is cargo culting an useless clearing done for "--glob" and friends to code for "--all" that did not do the same useless clearing. IOW, there are two ways to address the "inconsistency", and the proposed log message (nor your answer above) does not make a convincing argument why adding the same code to the "--all" side is the right way to achieve consistency---rather than removing the call to clear from the existing ones. Thanks.
